From 6175081b88701b7761748ca293ccfbefa1423cbc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rafa=C5=82=20Borcz?= Date: Mon, 3 Jun 2019 22:47:35 +0200 Subject: [PATCH 1/4] Fix tab layout crash on prelolipop (#399) --- app/build.gradle | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/build.gradle b/app/build.gradle index e88f74c66..c8ea5a252 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -106,7 +106,7 @@ dependencies { implementation "androidx.cardview:cardview:1.0.0" implementation 'androidx.constraintlayout:constraintlayout:1.1.3' - implementation "com.google.android.material:material:1.1.0-alpha07" + implementation "com.google.android.material:material:1.1.0-alpha05" implementation 'com.github.wulkanowy:MaterialChipsInput:b72fd0ee6f' implementation 'com.github.PhilJay:MPAndroidChart:v3.1.0' From 1d9a49d5529129f81d021e363320029ca5d025a6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miko=C5=82aj=20Pich?= Date: Tue, 4 Jun 2019 01:53:20 +0200 Subject: [PATCH 2/4] Add githook plugin (#398) --- app/build.gradle | 1 + app/hooks.gradle | 10 ++++++++++ app/play-publish-lint.sh | 7 +++++++ app/src/main/play/release-notes/pl-PL/default.txt | 2 +- build.gradle | 1 + 5 files changed, 20 insertions(+), 1 deletion(-) create mode 100644 app/hooks.gradle create mode 100755 app/play-publish-lint.sh diff --git a/app/build.gradle b/app/build.gradle index c8ea5a252..8a6b25ea4 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -6,6 +6,7 @@ apply plugin: 'io.fabric' apply plugin: 'com.github.triplet.play' apply from: 'jacoco.gradle' apply from: 'sonarqube.gradle' +apply from: 'hooks.gradle' android { compileSdkVersion 28 diff --git a/app/hooks.gradle b/app/hooks.gradle new file mode 100644 index 000000000..038fa9fb2 --- /dev/null +++ b/app/hooks.gradle @@ -0,0 +1,10 @@ +apply plugin: "com.star-zero.gradle.githook" + +githook { + failOnMissingHooksDir = false + hooks { + "pre-push" { + shell = "./app/play-publish-lint.sh" + } + } +} diff --git a/app/play-publish-lint.sh b/app/play-publish-lint.sh new file mode 100755 index 000000000..d3354b1ad --- /dev/null +++ b/app/play-publish-lint.sh @@ -0,0 +1,7 @@ +#!/bin/bash - + +content=$(cat < "app/src/main/play/release-notes/pl-PL/default.txt") || exit +if [[ "${#content}" -gt 500 ]]; then + echo >&2 "Release notes content has reached the limit of 500 characters" + exit 1 +fi diff --git a/app/src/main/play/release-notes/pl-PL/default.txt b/app/src/main/play/release-notes/pl-PL/default.txt index 7fe143d8e..e2048e1f9 100644 --- a/app/src/main/play/release-notes/pl-PL/default.txt +++ b/app/src/main/play/release-notes/pl-PL/default.txt @@ -2,7 +2,7 @@ Wersja 0.9.0 Dodaliśmy: - zarządzanie dostępem mobilnym do dziennika -- wyświetlanie sumy punktów (jeśli dziennik obsługuje) +- wyświetlanie sumy punktów - wyświetlanie informacji o wygasłej sesji, gdy zostanie zmienione hasło Naprawiliśmy: diff --git a/build.gradle b/build.gradle index 4ed9ec686..ac8a0926d 100644 --- a/build.gradle +++ b/build.gradle @@ -14,6 +14,7 @@ buildscript { classpath "io.fabric.tools:gradle:1.29.0" classpath "com.github.triplet.gradle:play-publisher:2.2.1" classpath "org.sonarsource.scanner.gradle:sonarqube-gradle-plugin:2.7.1" + classpath "gradle.plugin.com.star-zero.gradle:githook:1.1.0" } } From 83dbd9874e291009b630c6a7017808d247549d74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miko=C5=82aj=20Pich?= Date: Tue, 4 Jun 2019 02:27:15 +0200 Subject: [PATCH 3/4] Add option to force calc average by app (#400) --- .travis.yml | 6 +++--- .../preferences/PreferencesRepository.kt | 3 +++ .../ui/modules/grade/GradeAverageProvider.kt | 2 +- app/src/main/res/values-pl/strings.xml | 1 + app/src/main/res/values/preferences_keys.xml | 1 + app/src/main/res/values/strings.xml | 1 + app/src/main/res/xml/scheme_preferences.xml | 5 +++++ .../modules/grade/GradeAverageProviderTest.kt | 19 +++++++++++++++++++ 8 files changed, 34 insertions(+), 4 deletions(-) diff --git a/.travis.yml b/.travis.yml index 4c40f615f..0f54ff044 100644 --- a/.travis.yml +++ b/.travis.yml @@ -11,9 +11,9 @@ cache: - $HOME/.gradle/caches/ - $HOME/.gradle/wrapper/ -#branches: -# only: -# - develop +branches: + only: + - develop android: licenses: diff --git a/app/src/main/java/io/github/wulkanowy/data/repositories/preferences/PreferencesRepository.kt b/app/src/main/java/io/github/wulkanowy/data/repositories/preferences/PreferencesRepository.kt index bde84162d..bb9a39b1c 100644 --- a/app/src/main/java/io/github/wulkanowy/data/repositories/preferences/PreferencesRepository.kt +++ b/app/src/main/java/io/github/wulkanowy/data/repositories/preferences/PreferencesRepository.kt @@ -20,6 +20,9 @@ class PreferencesRepository @Inject constructor( val gradeAverageMode: String get() = sharedPref.getString(context.getString(R.string.pref_key_grade_average_mode), "only_one_semester") ?: "only_one_semester" + val gradeAverageForceCalc: Boolean + get() = sharedPref.getBoolean(context.getString(R.string.pref_key_grade_average_force_calc), false) + val isGradeExpandable: Boolean get() = !sharedPref.getBoolean(context.getString(R.string.pref_key_expand_grade), false) diff --git a/app/src/main/java/io/github/wulkanowy/ui/modules/grade/GradeAverageProvider.kt b/app/src/main/java/io/github/wulkanowy/ui/modules/grade/GradeAverageProvider.kt index cff602684..3f794ff1f 100644 --- a/app/src/main/java/io/github/wulkanowy/ui/modules/grade/GradeAverageProvider.kt +++ b/app/src/main/java/io/github/wulkanowy/ui/modules/grade/GradeAverageProvider.kt @@ -67,6 +67,6 @@ class GradeAverageProvider @Inject constructor( if (it.any { summary -> summary.average != .0 }) { Maybe.just(it.map { summary -> summary.subject to summary.average }.toMap()) } else Maybe.empty() - } + }.filter { !preferencesRepository.gradeAverageForceCalc } } } diff --git a/app/src/main/res/values-pl/strings.xml b/app/src/main/res/values-pl/strings.xml index 128d8636b..91d980a64 100644 --- a/app/src/main/res/values-pl/strings.xml +++ b/app/src/main/res/values-pl/strings.xml @@ -253,6 +253,7 @@ Wygląd Domyślny widok Obliczanie średniej końcoworocznej + Wymuś obliczanie średniej przez aplikację Pokazuj obecność we frekwencji Motyw aplikacji Rozwiń oceny diff --git a/app/src/main/res/values/preferences_keys.xml b/app/src/main/res/values/preferences_keys.xml index b09ee51bc..730fea591 100644 --- a/app/src/main/res/values/preferences_keys.xml +++ b/app/src/main/res/values/preferences_keys.xml @@ -6,6 +6,7 @@ grade_color_scheme expand_grade grade_average_mode + grade_average_always_calc services_enable services_interval services_disable_wifi_only diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index b64248767..fd94e5b68 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -237,6 +237,7 @@ Appearance Default view Calculation of the end-of-year average + Force average calculation by app Show presence in attendance Application theme Expand grades diff --git a/app/src/main/res/xml/scheme_preferences.xml b/app/src/main/res/xml/scheme_preferences.xml index 149024c03..ccacfe9db 100644 --- a/app/src/main/res/xml/scheme_preferences.xml +++ b/app/src/main/res/xml/scheme_preferences.xml @@ -105,6 +105,11 @@ android:summary="%s" android:title="@string/pref_view_grade_average_mode" app:iconSpaceReserved="false" /> + Date: Tue, 4 Jun 2019 02:43:50 +0200 Subject: [PATCH 4/4] Version 0.9.1 --- .travis.yml | 6 +++--- app/build.gradle | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.travis.yml b/.travis.yml index 0f54ff044..4c40f615f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -11,9 +11,9 @@ cache: - $HOME/.gradle/caches/ - $HOME/.gradle/wrapper/ -branches: - only: - - develop +#branches: +# only: +# - develop android: licenses: diff --git a/app/build.gradle b/app/build.gradle index 8a6b25ea4..586e988cd 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -17,8 +17,8 @@ android { testApplicationId "io.github.tests.wulkanowy" minSdkVersion 15 targetSdkVersion 28 - versionCode 38 - versionName "0.9.0" + versionCode 39 + versionName "0.9.1" multiDexEnabled true testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner" vectorDrawables.useSupportLibrary = true @@ -98,7 +98,7 @@ play { } dependencies { - implementation 'io.github.wulkanowy:api:0.9.0' + implementation 'io.github.wulkanowy:api:0.9.1' implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version" implementation "androidx.legacy:legacy-support-v4:1.0.0"