diff --git a/app/src/main/java/io/github/wulkanowy/utils/GradeUtils.java b/app/src/main/java/io/github/wulkanowy/utils/GradeUtils.java index d274da97..7b6ba193 100644 --- a/app/src/main/java/io/github/wulkanowy/utils/GradeUtils.java +++ b/app/src/main/java/io/github/wulkanowy/utils/GradeUtils.java @@ -49,29 +49,29 @@ public final class GradeUtils { public static int getValueColor(String value) { Matcher m1 = validGradePattern.matcher(value); if (!m1.find()) { - return R.color.default_grade; + return R.color.grade_default; } Matcher m2 = simpleGradeValuePattern.matcher(m1.group()); if (!m2.find()) { - return R.color.default_grade; + return R.color.grade_default; } switch (Integer.parseInt(m2.group())) { case 6: - return R.color.six_grade; + return R.color.grade_six; case 5: - return R.color.five_grade; + return R.color.grade_five; case 4: - return R.color.four_grade; + return R.color.grade_four; case 3: - return R.color.three_grade; + return R.color.grade_three; case 2: - return R.color.two_grade; + return R.color.grade_two; case 1: - return R.color.one_grade; + return R.color.grade_one; default: - return R.color.default_grade; + return R.color.grade_default; } } diff --git a/app/src/main/res/layout/grades_dialog.xml b/app/src/main/res/layout/grades_dialog.xml index c5cf073e..aceec78f 100644 --- a/app/src/main/res/layout/grades_dialog.xml +++ b/app/src/main/res/layout/grades_dialog.xml @@ -29,6 +29,8 @@ android:layout_gravity="end" android:gravity="center" android:text="@string/app_name" + android:textColor="@color/grade_text" + android:background="@color/grade_default" android:textSize="30sp" /> #9a0007 #ff6659 #f0f0f0 - #92b53d - #66B266 - #55BBDB - #FFE68C - #CE9AD2 - #d32f2f - #cdcdcd + + #ffffff + #91b43c + #2cbd92 + #50b6d6 + #d2ab24 + #9071b3 + #d65757 + #3d5f9c #4c4c4c #333 diff --git a/app/src/test/java/io/github/wulkanowy/utils/GradeUtilsTest.java b/app/src/test/java/io/github/wulkanowy/utils/GradeUtilsTest.java index 4bf6de51..54b298f2 100644 --- a/app/src/test/java/io/github/wulkanowy/utils/GradeUtilsTest.java +++ b/app/src/test/java/io/github/wulkanowy/utils/GradeUtilsTest.java @@ -62,18 +62,18 @@ public class GradeUtilsTest { @Test public void getValueColorTest() { - assertEquals(R.color.six_grade, GradeUtils.getValueColor("-6")); - assertEquals(R.color.five_grade, GradeUtils.getValueColor("--5")); - assertEquals(R.color.four_grade, GradeUtils.getValueColor("=4")); - assertEquals(R.color.three_grade, GradeUtils.getValueColor("3-")); - assertEquals(R.color.two_grade, GradeUtils.getValueColor("2--")); - assertEquals(R.color.two_grade, GradeUtils.getValueColor("2=")); - assertEquals(R.color.one_grade, GradeUtils.getValueColor("1+")); - assertEquals(R.color.one_grade, GradeUtils.getValueColor("+1")); - assertEquals(R.color.default_grade, GradeUtils.getValueColor("6 (.XI)")); - assertEquals(R.color.default_grade, GradeUtils.getValueColor("Np")); - assertEquals(R.color.default_grade, GradeUtils.getValueColor("7")); - assertEquals(R.color.default_grade, GradeUtils.getValueColor("")); + assertEquals(R.color.grade_six, GradeUtils.getValueColor("-6")); + assertEquals(R.color.grade_five, GradeUtils.getValueColor("--5")); + assertEquals(R.color.grade_four, GradeUtils.getValueColor("=4")); + assertEquals(R.color.grade_three, GradeUtils.getValueColor("3-")); + assertEquals(R.color.grade_two, GradeUtils.getValueColor("2--")); + assertEquals(R.color.grade_two, GradeUtils.getValueColor("2=")); + assertEquals(R.color.grade_one, GradeUtils.getValueColor("1+")); + assertEquals(R.color.grade_one, GradeUtils.getValueColor("+1")); + assertEquals(R.color.grade_default, GradeUtils.getValueColor("6 (.XI)")); + assertEquals(R.color.grade_default, GradeUtils.getValueColor("Np")); + assertEquals(R.color.grade_default, GradeUtils.getValueColor("7")); + assertEquals(R.color.grade_default, GradeUtils.getValueColor("")); } @Test