sadorowo/wulkanowy-mod
1
0
Fork 0
forked from github/wulkanowy-mirror
Code Issues Pull Requests Actions Releases 5 Activity

Fix grade summary empty view (#941)

Browse Source
This commit is contained in:
Mikołaj Pich 2020-09-01 23:57:56 +02:00 committed by GitHub
parent 2ad1d086e0
commit 0f65af8958
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/src/main/java/io/github/wulkanowy/ui/modules/grade/summary/GradeSummaryAdapter.kt
View File

@ -21,7 +21,7 @@ class GradeSummaryAdapter @Inject constructor() : RecyclerView.Adapter<RecyclerV
var items = emptyList<GradeSummary>() var items = emptyList<GradeSummary>()
override fun getItemCount() = items.size + 1 override fun getItemCount() = items.size + if (items.isNotEmpty()) 1 else 0
override fun getItemViewType(position: Int) = when (position) { override fun getItemViewType(position: Int) = when (position) {
0 -> ViewType.HEADER.id 0 -> ViewType.HEADER.id

9
app/src/main/java/io/github/wulkanowy/ui/modules/grade/summary/GradeSummaryPresenter.kt
View File

@ -45,16 +45,17 @@ class GradeSummaryPresenter @Inject constructor(
Status.LOADING -> Timber.i("Loading grade summary started") Status.LOADING -> Timber.i("Loading grade summary started")
Status.SUCCESS -> { Status.SUCCESS -> {
Timber.i("Loading grade summary result: Success") Timber.i("Loading grade summary result: Success")
val items = createGradeSummaryItems(it.data!!)
view?.run { view?.run {
showEmpty(it.data!!.isEmpty()) showEmpty(items.isEmpty())
showContent(it.data.isNotEmpty()) showContent(items.isNotEmpty())
showErrorView(false) showErrorView(false)
updateData(createGradeSummaryItems(it.data)) updateData(items)
} }
analytics.logEvent( analytics.logEvent(
"load_data", "load_data",
"type" to "grade_summary", "type" to "grade_summary",
"items" to it.data!!.size "items" to it.data.size
) )
} }
Status.ERROR -> { Status.ERROR -> {