From 729e0f547b301fcefc92f155a0e395f478e7b3d0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miko=C5=82aj=20Pich?= <m.pich@outlook.com>
Date: Thu, 16 May 2024 23:12:55 +0200
Subject: [PATCH] Add sandbox isolate

---
 app/build.gradle                              |  2 ++
 app/src/main/AndroidManifest.xml              |  4 ++-
 .../wulkanowy/data/WulkanowySdkFactory.kt     | 32 +++++++++++++++++--
 3 files changed, 35 insertions(+), 3 deletions(-)

diff --git a/app/build.gradle b/app/build.gradle
index 510d62e2..a6974079 100644
--- a/app/build.gradle
+++ b/app/build.gradle
@@ -197,6 +197,7 @@ dependencies {
 
     implementation "org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.3"
     implementation "org.jetbrains.kotlinx:kotlinx-coroutines-android:$coroutines"
+    implementation "org.jetbrains.kotlinx:kotlinx-coroutines-guava:$coroutines"
 
     implementation 'androidx.core:core-ktx:1.13.1'
     implementation 'androidx.core:core-splashscreen:1.0.1'
@@ -204,6 +205,7 @@ dependencies {
     implementation "androidx.appcompat:appcompat:1.6.1"
     implementation "androidx.fragment:fragment-ktx:1.7.0"
     implementation "androidx.annotation:annotation:1.7.1"
+    implementation "androidx.javascriptengine:javascriptengine:1.0.0-beta01"
 
     implementation "androidx.preference:preference-ktx:1.2.1"
     implementation "androidx.recyclerview:recyclerview:1.3.2"
diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml
index 79d75bc0..a4257893 100644
--- a/app/src/main/AndroidManifest.xml
+++ b/app/src/main/AndroidManifest.xml
@@ -3,6 +3,8 @@
     xmlns:tools="http://schemas.android.com/tools"
     android:installLocation="internalOnly">
 
+    <uses-sdk tools:overrideLibrary="androidx.javascriptengine" />
+
     <uses-permission android:name="android.permission.INTERNET" />
     <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
     <uses-permission android:name="android.permission.WAKE_LOCK" />
@@ -42,9 +44,9 @@
         android:icon="@mipmap/ic_launcher"
         android:label="@string/app_name"
         android:networkSecurityConfig="@xml/network_security_config"
+        android:resizeableActivity="true"
         android:supportsRtl="false"
         android:theme="@style/WulkanowyTheme"
-        android:resizeableActivity="true"
         tools:ignore="DataExtractionRules,UnusedAttribute">
         <activity
             android:name=".ui.modules.splash.SplashActivity"
diff --git a/app/src/main/java/io/github/wulkanowy/data/WulkanowySdkFactory.kt b/app/src/main/java/io/github/wulkanowy/data/WulkanowySdkFactory.kt
index dbd34cee..2931db35 100644
--- a/app/src/main/java/io/github/wulkanowy/data/WulkanowySdkFactory.kt
+++ b/app/src/main/java/io/github/wulkanowy/data/WulkanowySdkFactory.kt
@@ -1,14 +1,21 @@
 package io.github.wulkanowy.data
 
+import android.content.Context
+import android.os.Build
+import androidx.javascriptengine.JavaScriptSandbox
 import com.chuckerteam.chucker.api.ChuckerInterceptor
+import com.google.common.util.concurrent.ListenableFuture
+import dagger.hilt.android.qualifiers.ApplicationContext
 import io.github.wulkanowy.data.db.dao.StudentDao
 import io.github.wulkanowy.data.db.entities.Semester
 import io.github.wulkanowy.data.db.entities.Student
 import io.github.wulkanowy.data.db.entities.StudentIsEduOne
 import io.github.wulkanowy.data.repositories.WulkanowyRepository
 import io.github.wulkanowy.sdk.Sdk
+import io.github.wulkanowy.sdk.scrapper.EvaluateHandler
 import io.github.wulkanowy.utils.RemoteConfigHelper
 import io.github.wulkanowy.utils.WebkitCookieManagerProxy
+import kotlinx.coroutines.guava.await
 import kotlinx.coroutines.sync.Mutex
 import kotlinx.coroutines.sync.withLock
 import timber.log.Timber
@@ -17,6 +24,7 @@ import javax.inject.Singleton
 
 @Singleton
 class WulkanowySdkFactory @Inject constructor(
+    @ApplicationContext private val context: Context,
     private val chuckerInterceptor: ChuckerInterceptor,
     private val remoteConfig: RemoteConfigHelper,
     private val webkitCookieManagerProxy: WebkitCookieManagerProxy,
@@ -26,10 +34,14 @@ class WulkanowySdkFactory @Inject constructor(
 
     private val eduOneMutex = Mutex()
     private val migrationFailedStudentIds = mutableSetOf<Long>()
+    private val sandbox: ListenableFuture<JavaScriptSandbox>? =
+        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O && JavaScriptSandbox.isSupported())
+            JavaScriptSandbox.createConnectedInstanceAsync(context)
+        else null
 
     private val sdk = Sdk().apply {
-        androidVersion = android.os.Build.VERSION.RELEASE
-        buildTag = android.os.Build.MODEL
+        androidVersion = Build.VERSION.RELEASE
+        buildTag = Build.MODEL
         userAgentTemplate = remoteConfig.userAgentTemplate
         setSimpleHttpLogger { Timber.d(it) }
         setAdditionalCookieManager(webkitCookieManagerProxy)
@@ -48,6 +60,22 @@ class WulkanowySdkFactory @Inject constructor(
                 endpointsMapping = mapping.endpoints
                 vTokenMapping = mapping.vTokens
                 vTokenSchemeMapping = mapping.vTokenScheme
+                vParamsEvaluation = createIsolate()
+            }
+        }
+    }
+
+    private suspend fun createIsolate(): suspend () -> EvaluateHandler {
+        return {
+            val isolate = sandbox?.await()?.createIsolate()
+            object : EvaluateHandler {
+                override suspend fun evaluate(code: String): String? {
+                    return isolate?.evaluateJavaScriptAsync(code)?.await()
+                }
+
+                override fun close() {
+                    isolate?.close()
+                }
             }
         }
     }