From b19084cb579dce6a742364301bb40a290a80a30a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miko=C5=82aj=20Pich?= <m.pich@outlook.com>
Date: Sat, 18 Apr 2020 23:06:05 +0200
Subject: [PATCH] =?UTF-8?q?Fix=20visibility=20of=20dialog=20close=20button?=
 =?UTF-8?q?=20when=20homework=20content=20is=20l=E2=80=A6=20(#774)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 app/src/main/res/layout/dialog_homework.xml          | 12 ++++++------
 .../main/res/layout/item_homework_dialog_details.xml |  4 +++-
 2 files changed, 9 insertions(+), 7 deletions(-)

diff --git a/app/src/main/res/layout/dialog_homework.xml b/app/src/main/res/layout/dialog_homework.xml
index daa07636..7c149d4b 100644
--- a/app/src/main/res/layout/dialog_homework.xml
+++ b/app/src/main/res/layout/dialog_homework.xml
@@ -9,14 +9,18 @@
     <androidx.recyclerview.widget.RecyclerView
         android:id="@+id/homeworkDialogRecycler"
         android:layout_width="match_parent"
-        android:layout_height="wrap_content"
+        android:layout_height="0dp"
+        android:layout_weight="1"
         android:minWidth="300dp"
         tools:itemCount="1"
         tools:listitem="@layout/item_homework_dialog_details" />
 
     <androidx.constraintlayout.widget.ConstraintLayout
         android:layout_width="match_parent"
-        android:layout_height="wrap_content">
+        android:layout_height="wrap_content"
+        android:background="@drawable/ic_all_divider"
+        android:paddingHorizontal="10dp"
+        android:paddingVertical="5dp">
 
         <com.google.android.material.button.MaterialButton
             android:id="@+id/homeworkDialogRead"
@@ -25,8 +29,6 @@
             android:layout_height="wrap_content"
             android:layout_alignParentStart="true"
             android:layout_alignParentBottom="true"
-            android:layout_marginStart="10dp"
-            android:layout_marginBottom="10dp"
             android:text="@string/homework_mark_as_done"
             app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintStart_toStartOf="parent" />
@@ -38,8 +40,6 @@
             android:layout_height="wrap_content"
             android:layout_alignParentEnd="true"
             android:layout_alignParentBottom="true"
-            android:layout_marginEnd="10dp"
-            android:layout_marginBottom="10dp"
             android:text="@string/all_close"
             app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintEnd_toEndOf="parent" />
diff --git a/app/src/main/res/layout/item_homework_dialog_details.xml b/app/src/main/res/layout/item_homework_dialog_details.xml
index 4b368c62..bfd246c8 100644
--- a/app/src/main/res/layout/item_homework_dialog_details.xml
+++ b/app/src/main/res/layout/item_homework_dialog_details.xml
@@ -1,4 +1,5 @@
 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:orientation="vertical"
@@ -93,6 +94,7 @@
         android:lineSpacingMultiplier="1.2"
         android:text="@string/all_no_data"
         android:textIsSelectable="true"
-        android:textSize="12sp" />
+        android:textSize="12sp"
+        tools:text="@tools:sample/lorem/random" />
 
 </LinearLayout>