From baf14201933b396f2f6b806f01aa58e60de94e66 Mon Sep 17 00:00:00 2001
From: Dominik Korsa <dominik.korsa@gmail.com>
Date: Mon, 29 Apr 2019 00:55:30 +0200
Subject: [PATCH] Improve login student selection layout (#329)

---
 .../res/layout/item_login_student_select.xml  | 32 +++++++++++--------
 1 file changed, 19 insertions(+), 13 deletions(-)

diff --git a/app/src/main/res/layout/item_login_student_select.xml b/app/src/main/res/layout/item_login_student_select.xml
index eb74cebb..f896d99f 100644
--- a/app/src/main/res/layout/item_login_student_select.xml
+++ b/app/src/main/res/layout/item_login_student_select.xml
@@ -1,5 +1,4 @@
 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:id="@+id/loginItemContainer"
     android:layout_width="match_parent"
@@ -9,34 +8,41 @@
 
     <CheckBox
         android:id="@+id/loginItemCheck"
-        android:layout_width="26dp"
+        android:layout_width="32dp"
         android:layout_height="24dp"
-        android:layout_marginStart="16dp"
-        android:layout_marginLeft="16dp"
-        android:layout_marginTop="16dp"
-        android:layout_marginEnd="32dp"
-        android:layout_marginRight="32dp"
+        android:layout_marginStart="12dp"
+        android:layout_marginLeft="12dp"
+        android:layout_marginTop="24dp"
+        android:layout_marginEnd="28dp"
+        android:layout_marginRight="28dp"
+        android:layout_marginBottom="24dp"
         tools:text=" " />
 
     <TextView
         android:id="@+id/loginItemName"
         android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
+        android:layout_height="34dp"
+        android:layout_marginEnd="16dp"
+        android:layout_marginRight="16dp"
         android:layout_toEndOf="@id/loginItemCheck"
         android:layout_toRightOf="@id/loginItemCheck"
+        android:gravity="bottom"
         android:textSize="16sp"
-        app:firstBaselineToTopHeight="32dp"
-        tools:text="Jan Kowalski" />
+        tools:text="@tools:sample/full_names" />
 
     <TextView
         android:id="@+id/loginItemSchool"
         android:layout_width="wrap_content"
-        android:layout_height="wrap_content"
+        android:layout_height="20dp"
         android:layout_below="@id/loginItemName"
+        android:layout_marginEnd="16dp"
+        android:layout_marginRight="16dp"
         android:layout_toEndOf="@id/loginItemCheck"
         android:layout_toRightOf="@id/loginItemCheck"
+        android:ellipsize="end"
+        android:gravity="bottom"
+        android:maxLines="1"
         android:textColor="?android:textColorSecondary"
         android:textSize="12sp"
-        app:firstBaselineToTopHeight="20dp"
-        tools:text="Szkoła Wulkanowego nr 1" />
+        tools:text="@tools:sample/lorem/random" />
 </RelativeLayout>